feat: 🎸 [JIRA: HCPSDKFIORIUIKIT-2764] list picker enhancement #823
+3,593
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xiaoyu0722
commented
Oct 14, 2024
•
xiaoyu0722
commented
| Debug Panel | Normal Single Selection | Multiple Selections |
|---|---|---|
| Search | Filter | Cancel Alert | Customizaiton |
|---|---|---|---|
![hound[bot]](https://github.com/avatars/in/3598?s=60&v=4){kind=small}
| // sourcery: default.value = .horizontal | ||
| // sourcery: no_view | ||
| var axis: Axis { get } | ||
| } | ||
|
|
||
| @available(*, unavailable, renamed: "_ListPickerItemModel", message: "Will be removed in the future release. Please create ListPickerItem with other initializers instead.") | ||
| public protocol ListPickerItemModel {} |
There was a problem hiding this comment.
Missing Docs Violation: public declarations should be documented. (missing_docs)
xiaoyu0722
force-pushed
the
fix-list-picker-enhancement
branch
from
ced5b72
to
02f3d4a
Compare
dyongxu
reviewed
Oct 14, 2024
| @@ -569,3 +569,37 @@ protocol _DateTimePickerComponent: _TitleComponent, _ValueLabelComponent, _Manda | |||
|
|
|||
| // sourcery: CompositeComponent | |||
| protocol _AvatarStackComponent: _AvatarsComponent, _AvatarsTitleComponent {} | |||
|
|
|||
| /// `ListPickerItem` is a view that provide a `NavigationLink` with a title and selected value. And `ListPickerDestination` is recommended to be used as its destination, which selection, search filter and customized rows are supported. | |||
There was a problem hiding this comment.
Suggested change
| /// `ListPickerItem` is a view that provide a `NavigationLink` with a title and selected value. And `ListPickerDestination` is recommended to be used as its destination, which selection, search filter and customized rows are supported. | |
| /// `ListPickerItem` is a view that provides a `NavigationLink` with a title and selected value(s). And `ListPickerDestination` is recommended to be used as its destination, for which selection, search filter and customized rows are supported. |
dyongxu
reviewed
Oct 14, 2024
| import FioriSwiftUICore | ||
| import SwiftUI | ||
|
|
||
| struct ListPickerItemExample: View { |
There was a problem hiding this comment.
In UIKit, the list picker can group some values in sections.
e.g.
Section 1 for all apples
Section 2 for all pears
Section 3 for all grapes
Currently, looks like only "Selected" and "All" section are supported.
Do this new implementation support multiple "group" idea as well ? If yes, can we add some new cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.