Skip to content

Commit

Permalink
chore: make required modules for FioriSwiftUI target/library also ava…
Browse files Browse the repository at this point in the history
…ilable for MacCatalyst (#670)

I observed this issue when trying to use FioriSwiftUI package in a framework and using
FioriSwiftUI umbrella library. The framework, when compiling for MacCatalyst, complains
for `import FioriThemeManager`.

The conditional target handling, introduced for supporting visionOS, requires us to specify
the macCatalyst platform. A regression issue but no customer noticed that because we
didn't create a new release yet.
  • Loading branch information
MarcoEidinger authored Mar 26, 2024
1 parent 20e62c7 commit a516704
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ let package = Package(
targets: [
.target(
name: "FioriSwiftUI",
dependencies: [.target(name: "FioriSwiftUICore", condition: .when(platforms: [.iOS, .visionOS]))]
dependencies: [.target(name: "FioriSwiftUICore", condition: .when(platforms: [.iOS, .macCatalyst, .visionOS]))]
),
.target(
name: "FioriCharts",
Expand All @@ -38,8 +38,8 @@ let package = Package(
.target(
name: "FioriSwiftUICore",
dependencies: [
.target(name: "FioriThemeManager", condition: .when(platforms: [.iOS, .visionOS])),
.target(name: "FioriCharts", condition: .when(platforms: [.iOS, .visionOS]))
.target(name: "FioriThemeManager", condition: .when(platforms: [.iOS, .macCatalyst, .visionOS])),
.target(name: "FioriCharts", condition: .when(platforms: [.iOS, .macCatalyst, .visionOS]))
],
resources: [.process("_localization")]
),
Expand Down

0 comments on commit a516704

Please sign in to comment.