Pinned TypeShape version to 8.0.1 to fix deployment issue #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -381,8 +381,9 @@ NUGET | |||
| Thoth.Json (5.1) | |||
| Fable.Core (>= 3.1.6) | |||
| FSharp.Core (>= 4.7.2) | |||
| TypeShape (9.0) | |||
| FSharp.Core (>= 4.3.2) | |||
| TypeShape (8.0.1) | |||
There was a problem hiding this comment.
I would recommend avoiding taking a nuget dependency and embed the source file directly. You can then pin the version of the library you depend on at compile time.
theimowski
added a commit
that referenced
this pull request
Mar 14, 2021
|
a08bd5b updates Fable.Remoting.Server to latest and removes transitive TypeShape dependency (see Zaid-Ajaj/Fable.Remoting@42bfab7) |
|
I think we can close this PR without merging? |
|
Yeah Fable.Remoting no longer requires TypeShape as a nuget dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running an azure deployment would break since a different version of TypeShape was being used (9.0.0)
For more details - Zaid-Ajaj/Fable.Remoting#226