Navbar addition- Sylvester and Eddy #69
Conversation
The Navbar code(jsx,module.css) and App (jsx) update for the navbar function. Navbar(s) should be in a folder in Pages andApp.jsx needs a update for functionality
Add files via upload
ItsJonasL
requested review from
v74c63t,
ItsJonasL,
DorisSanchez-Velasquez and
Goketech
There was a problem hiding this comment.
These are the errors that the linter is complaining about. These should be fairly simple fixes.
You can view this information by clicking on Details.
Some changes I would suggest would be changing px to either em or rem in the css file for Navbar to make it more responsive. Also, the Navbar folder and its files should be under the Components folder, which is under frontend/src. And just wondering, are you editing the already existing App.jsx file? From this pull request, it looks like you created a new folder with the App files copied over instead of directly editing the App files under frontend/src/Pages/App. Can you copy over those changes to frontend/src/Pages/App/App.jsx instead? And move the Navbar folder into frontend/src/Components.
Lastly, can you include a image of the navbar so others reviewing the pull request can easily see what you did?
Add Navbar Test
| @@ -0,0 +1,4 @@ | |||
| .app-page{ | |||
There was a problem hiding this comment.
Looks great, awesome work! Only change requested is to move this css file under the App folder in the frontend folder. And delete the extra App Folder so that this PR only has the Frontend/app folder.
These are the files for the Navbar. The changes made are the new Navbar folder in Pages. They are Navbar.jsx, Navbar.module.css, App.jsx and