Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slouis07 accountinfocode #54

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

Slouis07 accountinfocode #54

wants to merge 62 commits into from

Conversation

Slouis07
Copy link
Collaborator

@Slouis07 Slouis07 commented Jan 5, 2024 •
edited

toggle private account page edit profile account page

@Slouis07
accountinfoskelcode
75bbb0c 
There is an issue with the toggle button functionality that I am trying to fix.
@Slouis07
accountinfopagecode *Toggle fixed
6dbd9a6
@Slouis07
Update Accountinfoskeletonhtml.jsx
e6a7f22 
fixed code with toggle working
@Slouis07
Update accountinfocss.jsx
9e54b92 
code with working toggle
@Slouis07
Update accountinfojs.jsx
f302ca9 
code with working toggle
@Slouis07
Delete Accountinfoskeletonhtml.jsx
bb6161e
@Slouis07
Delete accountinfojs.jsx
6780f0e
@Slouis07
Delete accountinfocss.jsx
0c2faad
@Slouis07
accountinfo.jsx
b015dd3 
rename
@Slouis07
Rename accountinfopagehtml.jsx to accountinfoH.jsx
3adf7ef
@Slouis07
accountinfopage.jsx
f3b37a9 
renamed js
@Slouis07
accountinfochanged.jsx
5f676a8
@Slouis07
Delete accountinfopage.jsx
46cbc3d 
deleted bc html and javascript should be together
@Slouis07
accountinfocss.jsx
08bae4f 
renamed css
@Slouis07
accountinfo.jsx
d4426bd 
renamed to fix issues
@Slouis07
accountinfo.jsx
b6aa4a1 
updated to example jsx
@Slouis07
accountinfo.jsx
160934a
@Slouis07
accountinfo.jsx
ca1563f
@Slouis07
accountinfo.jsx
40a3cb2
@Slouis07
accountinfo.jsx
f2b7277
@Slouis07
accountinfo.jsx
9032d43
@Slouis07
accountinfo.jsx
28a1143
@Slouis07
accountinfo.jsx
50a6a02
@Slouis07
accountinfo.jsx
73c5d13
@Slouis07
accountinfo.jsx
35a41c2 
updating to pass linter
@Slouis07
accountinfocss.jsx
94ab191 
fixing to run linter
@Slouis07
accountinfocss.jsx
31fbb5f 
fixing linter issue
@Slouis07
accountinfocss.jsx
d9ea7ae 
trying to fix linter
@Slouis07
accountinfocss.jsx
a673913 
fixing linter
@Slouis07
accountinfocss.jsx
50e2398 
to fix linter
DorisSanchez-Velasquez
DorisSanchez-Velasquez requested changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@DorisSanchez-Velasquez DorisSanchez-Velasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome!! Just some minor adjustments needed for the CSS and one-liner

accountinfo.module.css Outdated Show resolved Hide resolved
accountinfo.jsx Outdated Show resolved Hide resolved
DorisSanchez-Velasquez
DorisSanchez-Velasquez requested changes Feb 2, 2024
View reviewed changes
accountinfo.jsx Show resolved Hide resolved
accountinfo.jsx Outdated Show resolved Hide resolved
@Slouis07
accountinfo.jsx
3b6457d 
<React.Fragment> move
v74c63t
v74c63t requested changes Feb 24, 2024
View reviewed changes
Copy link
Collaborator

@v74c63t v74c63t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure that this page appears properly when running React. This may have the same problem as SinglePost(#65) in which the styles are being applied incorrectly and don't show up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v74c63t v74c63t v74c63t requested changes

@DorisSanchez-Velasquez DorisSanchez-Velasquez DorisSanchez-Velasquez requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Slouis07 @v74c63t @DorisSanchez-Velasquez