der: fix handling of oversized unsigned INTEGER inputs
#447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used `saturating_sub` rather than `checked_sub` to compute the number of leading zeroes to use, which would cause a panic if the input exceeded the output (see #446). This commit switches to `checked_sub`, returning `ErrorKind::Length` in the event the output buffer is too small for the given input. It also adds unit tests for this behavior as well as the happy paths.
bstrie
added a commit
to bstrie/trophy-case
that referenced
this pull request
Feb 27, 2022
Fixed in RustCrypto/formats#447 .
bstrie
added a commit
to bstrie/trophy-case
that referenced
this pull request
Feb 27, 2022
Fixed in RustCrypto/formats#447 .
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation used
saturating_subrather thanchecked_subto compute the number of leading zeroes to use, which would cause a panic if the input exceeded the output (see #446).This commit switches to
checked_sub, returningErrorKind::Lengthin the event the output buffer is too small for the given input. It also adds unit tests for this behavior as well as the happy paths.