Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCC audit fixes #256

Merged
merged 3 commits into from
Jul 1, 2023
Merged

NCC audit fixes #256

merged 3 commits into from
Jul 1, 2023

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Jun 28, 2023

Some small things that were picked up by the security audit.

  • Removed conditionals in Uint::saturating_add and saturating_sub and replaced them with constant-time methods.
  • Made checks in the random_mod test more logical
  • Marked Uint::sqrt to be renamed to sqrt_vartime (and similarly checked_sqrt and wrapping_sqrt) on the next breaking release, since that's the crate's convention.

@fjarri fjarri force-pushed the audit-fixes branch 2 times, most recently from c482261 to f9f1461 Compare June 28, 2023 23:55
tests/proptests.rs Outdated Show resolved Hide resolved
src/uint/sqrt.rs Outdated Show resolved Hide resolved
@tarcieri tarcieri merged commit 189449f into RustCrypto:master Jul 1, 2023
15 checks passed
@fjarri fjarri deleted the audit-fixes branch August 2, 2023 22:03
@tarcieri tarcieri mentioned this pull request Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants