Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic in lewton::audio::floor_decode on malformed input #44

Closed
Shnatsel opened this issue Feb 26, 2019 · 4 comments
Closed

Panic in lewton::audio::floor_decode on malformed input #44

Shnatsel opened this issue Feb 26, 2019 · 4 comments
Labels
bug

Comments

@Shnatsel
Copy link
Contributor

Error message: 'index out of bounds: the len is 42 but the index is 128'

Command to reproduce the crash:
RUSTFLAGS='--cfg=fuzzing' cargo run --release --example perf /path/to/testcase

Tested on commits 2c64469 and 0d13bc4, reproducible on both. Found using afl.rs

I'm sorry I keep breaking your stuff 😅
@Shnatsel
Copy link
Contributor Author

Forgot the test samples:
yet-another-oor.zip

@est31 est31 added the bug label Feb 27, 2019
@BenSandeen
Copy link
Contributor

I think I'm gonna take a stab at this if no one else is

BenSandeen added a commit to BenSandeen/lewton that referenced this issue Mar 1, 2019
@BenSandeen
Address issue at RustAudio#44
86bf2b7
est31 pushed a commit that referenced this issue Mar 2, 2019
@BenSandeen @est31
Address issue #44 (#45)
9078060 
Address issue #44
@est31
Copy link
Member

est31 commented Mar 2, 2019

Commit 9078060 has fixed the issue itself, all that remains is addition of a testcase.

@est31
Copy link
Member

est31 commented Mar 2, 2019

Ok these are the repacked files:

Only took the first two because I think the bug is not very tricky in itself.

@est31 est31 closed this as completed in 075a525 Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Shnatsel @est31 @BenSandeen