ENG 2332 Differentiate warning between pending and upstream failure #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunice-chan
added
the
skip_integration_test
agiron123
reviewed
Feb 13, 2023
| @@ -205,10 +205,69 @@ const ArtifactDetailsPage: React.FC<ArtifactDetailsPageProps> = ({ | |||
| const inputs = mapOperators([artifact.from]); | |||
| const outputs = mapOperators(artifact.to ? artifact.to : []); | |||
|
|
|||
| let upstream_pending = false; | |||
| inputs.some((operator) => { | |||
There was a problem hiding this comment.
Just curious, why are you using some here instead of filter?
There was a problem hiding this comment.
I only want to check whether any of the upstream operators are pending. some terminates on first True whereas filter will create another array with all that matches the criteria. We might want to use filter in the future if we want to display something for the pending operators but for now, I am not doing that.
agiron123
reviewed
Feb 13, 2023
agiron123
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
Correct artifact messaging.
Unable to reproduce other observations: https://linear.app/aqueducthq/issue/ENG-2332#comment-a9e27957
Related issue number (if any)
ENG 2332
Demo (if any)
Update messaging if input is pending for metric & operator artifacts:
Messaging remains correct in failure case:
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)