Rename integration to resources in our codebase #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likawind
approved these changes
May 24, 2023
likawind
reviewed
May 24, 2023
| resource_id: uuid.UUID = Field(alias="integration_id") | ||
| parameters: Union[str, UnionExtractParams] | ||
|
|
||
| class Config: |
There was a problem hiding this comment.
cc @kenxu95 confirming these are for fields preserved in database?
kenxu95
added
the
skip_integration_test
|
Ran the integration tests locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This is just a combination of all the previous renaming PRs from #1335 to #1341, rebased onto latest main and with the merge conflicts resolved. I accidentally merged those into
rc_v033last sunday which was a mistake, hence this gigantic PR.Testing:
Related issue number (if any)
ENG-2780
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)