Adjust padding around icons in resources/ and dag view #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsreekanti
approved these changes
May 23, 2023
|
Nice work! These two are still a bit off center. The others look fine though. |
agiron123
approved these changes
May 23, 2023
|
@agiron123 yeah I think that's just cus that icon is cropped inconsistently from the others so it has a different width.... |
|
Going to merge this as-in since it's a strict improvement for now. |
kenxu95
added
the
skip_integration_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
I'm actually not sure if these are actually improvements anymore, but wanted to send it out just in case any of these appealed to you guys.
On the DAG view, for operators, I removed the padding so that there wasn't as large of a gap between the header icon the text.
On the resources/ page, I made everything justified with the left side since it looked a little funny, but I'm not sure it looks any better.
OLD:
NEW:
OLD:
NEW:
Related issue number (if any)
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)