Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression of fetching flow by name #1357

Merged
merged 1 commit into from
May 23, 2023

Conversation

jpurusho65
Copy link
Contributor

Describe your changes and why you are making these changes

Map flow name to uuid before before fetching from backend instead of using name.

Related issue number (if any)

ENG-3019

Loom demo (if any)

Checklist before requesting a review

  • [ X] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • [ X] I have performed a self-review of my code.
  • [X ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • [ X] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • [X ] All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@jpurusho65
Copy link
Contributor Author

Screen Shot 2023-05-23 at 12 11 34 PM

@jpurusho65 jpurusho65 self-assigned this May 23, 2023
@jpurusho65 jpurusho65 requested a review from kenxu95 May 23, 2023 19:17
@jpurusho65 jpurusho65 force-pushed the eng-3019-querying-flow-by-name-does-not-work branch 2 times, most recently from ab03283 to 7208f8b Compare May 23, 2023 19:29
@jpurusho65 jpurusho65 force-pushed the eng-3019-querying-flow-by-name-does-not-work branch from 7208f8b to eb2120c Compare May 23, 2023 19:37
Had to map the flow name to uuid before before fetching from backend
Fix corresponding test case
@jpurusho65 jpurusho65 force-pushed the eng-3019-querying-flow-by-name-does-not-work branch from eb2120c to eef8967 Compare May 23, 2023 19:39
@jpurusho65 jpurusho65 added the run_integration_test Triggers integration tests label May 23, 2023
@jpurusho65 jpurusho65 merged commit df5a96d into main May 23, 2023
@jpurusho65 jpurusho65 deleted the eng-3019-querying-flow-by-name-does-not-work branch May 23, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants