Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 2885 create and test metric and check routes #1323

Merged
merged 15 commits into from
May 17, 2023

Conversation

eunice-chan
Copy link
Contributor

Describe your changes and why you are making these changes

Node Metric & Check get and content-get routes.

Same issue with content-get tests as the existing content-get routes so added the content-get tests to the task to investigate the error (ENG-2943)

Related issue number (if any)

ENG-2885
ENG-2943

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • [N/A] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [N/A] If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • [N/A] All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@eunice-chan eunice-chan added the run_integration_test Triggers integration tests label May 15, 2023
Copy link
Contributor

@agiron123 agiron123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but could use a little cleanup, particularly in the area of removing comments before it's good to go.

Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Appreciate again for adding all tests. I have a couple of naming / organization comments but it should be good to go once these comments are addressed!

Copy link
Contributor

@likawind likawind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Appreciate again for adding all tests. I have a couple of naming / organization comments but it should be good to go once these comments are addressed!

@likawind likawind merged commit 1c31857 into main May 17, 2023
@likawind likawind deleted the eng-2885-create-metric-and-check-routes branch May 22, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants