Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change aqueduct_demo name to Demo #1289

Merged
merged 6 commits into from
May 5, 2023

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented May 4, 2023

Describe your changes and why you are making these changes

This PR does a number of things;

  1. For aethestic purposes, we now call the demo db "Demo" instead of "aqueduct_demo".
  2. We delete the "AqueductDemo" service type, which is a vestige of old and never used.
  3. We add some logic to aqueduct startup, so that if a SQLite integration named "aqueduct_demo" exists, we'll delete it, with the assumption that the "Demo" entry will be created right afterwards. This, of course, means that we do not allow the user to create SQLite integrations named "aqueduct_demo".
  4. The user can still use client.resource("aqueduct_demo") if they want. We'll translate it to "Demo" implicitly for them, after printing out a warning.
  5. We remove the blocking of anything named "aqueduct_demo" on the frontend, and instead like the connect_integration route handle the validation. This improves error surfacing.

Screen Shot 2023-05-04 at 3 15 50 PM

Related issue number (if any)

ENG-2824

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@kenxu95 kenxu95 requested review from agiron123 and cw75 May 4, 2023 22:44
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@agiron123 agiron123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend should be okay ... I think. I'm still working on getting the new Kubernetes dialog to work with my forms refactor :sadpanda:

@kenxu95 kenxu95 added the run_integration_test Triggers integration tests label May 5, 2023
@kenxu95 kenxu95 merged commit f5c4900 into main May 5, 2023
@kenxu95 kenxu95 deleted the eng-2824-update-aqueduct_demo-to-demo branch May 5, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants