Add Databricks Periodic Integration tests #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubbaraj-spiral
force-pushed
the
eng-2846-add-databricksspark-integration-tests-to
branch
from
0f9bc74
to
f9fdf52
Compare
kenxu95
approved these changes
May 3, 2023
| @@ -0,0 +1,58 @@ | |||
| name: Spark Periodic Integration Tests | |||
There was a problem hiding this comment.
Curious why we separated this from the other periodic tests?
There was a problem hiding this comment.
I did this originally because of the different schedule, the spark tests run once a week vs every day (due to machine cost of running the databricks tests.)
There was a problem hiding this comment.
ah I see. What's the cost for each run? I wonder if we should do twice a week at least (eg. tuesday and friday)
kenxu95
reviewed
May 3, 2023
|
|
||
| - name: Run the SDK Integration Tests | ||
| working-directory: integration_tests/sdk | ||
| run: pytest aqueduct_tests/ -rP -vv -n 1 |
There was a problem hiding this comment.
Also, do things fail if we crank the concurrency up? It might make things a lot faster (you may have to provision a slightly beefier machine though).
There was a problem hiding this comment.
Will experiment with this before merging
hsubbaraj-spiral
force-pushed
the
eng-2846-add-databricksspark-integration-tests-to
branch
2 times, most recently
from
06f5452
to
f4f3fb7
Compare
added 16 commits
May 5, 2023 17:20
hsubbaraj-spiral
force-pushed
the
eng-2846-add-databricksspark-integration-tests-to
branch
from
f4f3fb7
to
979c428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
Add Databricks Periodic Integration tests
Related issue number (if any)
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)