Adds status checks for integration test Redshift cluster #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurav-c
commented
Apr 27, 2023
saurav-c
added
the
skip_integration_test
kenxu95
approved these changes
Apr 28, 2023
| mention_users: ${{ env.ONCALL_SLACK_MEMBER_ID }} | ||
| env: | ||
| SLACK_WEBHOOK_URL: ${{ secrets.ACTION_MONITORING_SLACK }} | ||
| # - name: Get the Slack ID for the current oncall |
There was a problem hiding this comment.
It's probably good for us to set timeouts for both the setup and teardown steps here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR adds some extra checking to make sure the Redshift cluster is in the correct state when resuming and pausing it before/after the data integration tests.
See example github action here as a test: https://github.com/aqueducthq/aqueduct/actions/runs/4825449922/jobs/8596314618
Related issue number (if any)
ENG 2776
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)