Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce concurrency of k8s tests to 1 #1222

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

hsubbaraj-spiral
Copy link
Contributor

Describe your changes and why you are making these changes

Reduces concurrency of K8s tests to 1 for stability reasons. Sets the timeout to 180 min to account for test time. Created a task to track the investigation of the test failures with higher concurrency.

Related issue number (if any)

Eng-2811

Loom demo (if any)

https://github.com/aqueducthq/aqueduct/actions/runs/4726107721 Run of the periodic tests.

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@hsubbaraj-spiral hsubbaraj-spiral added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 18, 2023
Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice - just one comment about downgrading the machine power too?

@@ -8,7 +8,7 @@ on:
jobs:
run-k8s-tests:
runs-on: ubuntu-latest-4-cores
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we actually try to downgrade this to ubuntu-latest? I don't think we need anything that powerful if we're just doing concurrency 1. We might need to bump the timeout to something slightly more generous for the first run though.

@hsubbaraj-spiral hsubbaraj-spiral merged commit e1c1bbe into main Apr 18, 2023
@hsubbaraj-spiral hsubbaraj-spiral deleted the eng-2811-reduce-concurrency-of-k8s-tests-to-1 branch April 18, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants