Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for running BigQuery tests periodically #1195

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

saurav-c
Copy link
Contributor

@saurav-c saurav-c commented Apr 11, 2023

Describe your changes and why you are making these changes

This PR fetches the BigQuery shared credentials to a location from which it can be used for data integration tests.

Related issue number (if any)

ENG 2696

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@saurav-c saurav-c force-pushed the eng-2696-add-bigquery-credentials-file-to-s3 branch from 36a1214 to d4e7384 Compare April 12, 2023 20:50
@saurav-c saurav-c marked this pull request as ready for review April 12, 2023 20:51
@saurav-c saurav-c requested review from kenxu95 and cw75 April 12, 2023 20:51
@saurav-c saurav-c added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 12, 2023
@vsreekanti
Copy link
Contributor

@cw75 @kenxu95, since Saurav's out for a while, one of you should merge this when you are comfortable.

@cw75 cw75 merged commit eabd084 into main Apr 14, 2023
@cw75 cw75 deleted the eng-2696-add-bigquery-credentials-file-to-s3 branch April 14, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants