Get sdk integration tests working with Spark #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 10, 2023 04:01
kenxu95
requested changes
Apr 10, 2023
| @@ -27,7 +27,7 @@ func NewSparkJobManager(conf *SparkJobManagerConfig) (*SparkJobManager, error) { | |||
|
|
|||
| session, err := livyClient.CreateSession(&spark.CreateSessionRequest{ | |||
| Kind: "pyspark", | |||
| HeartbeatTimeoutInSecond: 600, | |||
| HeartbeatTimeoutInSecond: 10, | |||
There was a problem hiding this comment.
I assume this was a necessary change to get it working with the test suite? This seems like quite a large numeric change - what are the ramifications of this?
There was a problem hiding this comment.
So I originally had the Heartbeat timeout set to 10 min for debugging purposes. It left the livy-created spark session alive so I could look at the logs. Realized we can actually check the logs of completed Spark sessions/applications via the Spark UI, so there isn't a need to keep these sessions alive. This also improves memory usage, since each SparkSession is allocated certain amount of disk space on the driver/worker nodes it uses.
kenxu95
approved these changes
Apr 11, 2023
added 2 commits
April 11, 2023 17:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
Modifies tests to work with Spark. Most of the changes involve adding a case in the test functions to use Pyspark Dataframe specific code. I also add the
pytest.mark.skip_for_spark_engines()fixture to skip tests that don't work with Spark.Related issue number (if any)
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)