Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md with some advice about install_local.py #1184

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented Apr 7, 2023

Describe your changes and why you are making these changes

I was just going over the CONTRIBUTING.md since I'd like to link that to our contributor. It looks good but I wonder if we can help them save some time by not having to rebuild the UI each time if they don't have to?

Related issue number (if any)

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@kenxu95 kenxu95 requested review from cw75 and likawind April 7, 2023 21:00
@likawind
Copy link
Contributor

likawind commented Apr 7, 2023

Thanks!! This will be very helpful!

@kenxu95 kenxu95 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 7, 2023
@kenxu95 kenxu95 merged commit e783af4 into main Apr 7, 2023
@kenxu95 kenxu95 deleted the add-install-local-advice-to-contributing branch April 7, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants