Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-2640: MySQL periodic integration test #1179

Merged
merged 13 commits into from
Apr 14, 2023
Merged

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Apr 6, 2023

Describe your changes and why you are making these changes

Creating another branch to see if still issues with gh actions

Related issue number (if any)

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123 agiron123 added the run_integration_test Triggers integration tests label Apr 6, 2023
@agiron123 agiron123 force-pushed the eng-2640-mysql-periodic-tests branch from ed2881a to 244e1f6 Compare April 12, 2023 23:48
@@ -127,7 +144,7 @@ jobs:
with:
aws_access_key_id: ${{ secrets.KENNY_AWS_ACCESS_KEY_ID }}
aws_secret_access_key: ${{ secrets.KENNY_AWS_SECRET_ACCESS_KEY }}
s3_test_config_path: periodic-data-integration-test-config.yml
s3_test_config_path: periodic-data-integration-test-config-agiron123.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change back to normal test-config when done with this PR.

@agiron123 agiron123 changed the title mysql periodic integration test ENG-2640: MySQL periodic integration test Apr 13, 2023
@agiron123 agiron123 requested a review from kenxu95 April 13, 2023 22:56
Copy link
Contributor

@kenxu95 kenxu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, remember to change the test-config.yml file back.

@agiron123 agiron123 merged commit 003bf75 into main Apr 14, 2023
@agiron123 agiron123 deleted the eng-2640-mysql-periodic-tests branch April 14, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_integration_test Triggers integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants