Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-2753: Fix issue where warning level checks show as failed in history list. #1175

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

agiron123
Copy link
Contributor

@agiron123 agiron123 commented Apr 5, 2023

Describe your changes and why you are making these changes

This PR fixes an issue where check history list items are incorrectly rendered for warning checks that fail.

Now they should show up with the warning logo and warning background color.

Related issue number (if any)

ENG-2753

Loom demo (if any)

https://www.loom.com/share/461760bd7c344397b04fe34e3615e69f

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@agiron123 agiron123 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 5, 2023
@agiron123 agiron123 changed the title Fix issue where warning level checks show as failed in hsitory list. ENG-2753: Fix issue where warning level checks show as failed in hsitory list. Apr 5, 2023
@agiron123 agiron123 changed the title ENG-2753: Fix issue where warning level checks show as failed in hsitory list. ENG-2753: Fix issue where warning level checks show as failed in history list. Apr 6, 2023
@agiron123 agiron123 merged commit aa803d8 into main Apr 6, 2023
@agiron123 agiron123 deleted the eng-2753-check-history-not-rendering-correctly branch April 6, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants