Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only upload terraform directory when the K8s cleanup fails #1145

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

kenxu95
Copy link
Contributor

@kenxu95 kenxu95 commented Mar 28, 2023

Describe your changes and why you are making these changes

This is a small tweak to make sure we aren't uploading 0.5 GBs of artifact data on every periodic failure - only when the cluster cleanup fails, since the point of uploading this artifact is to finish cluster deletion in such cases.

Related issue number (if any)

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@kenxu95 kenxu95 requested a review from cw75 March 28, 2023 19:16
@kenxu95 kenxu95 force-pushed the fix_overly_sensitive_workflow_upload branch from 3a7bef0 to 9458f57 Compare April 3, 2023 17:13
@kenxu95 kenxu95 added the skip_integration_test Skips required integration test (only documentation/UI changes) label Apr 3, 2023
@kenxu95 kenxu95 merged commit 951a813 into main Apr 3, 2023
@kenxu95 kenxu95 deleted the fix_overly_sensitive_workflow_upload branch April 3, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants