Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-2645] Fixes bug where next run button was broken on the UI #1118

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

vsreekanti
Copy link
Contributor

Describe your changes and why you are making these changes

This PR fixes a bug where the internal state management of the workflow details page wasn't correctly being kept in sync with the Redux store. As a result, the next/previous navigation buttons were broken.

This PR also fixes a bug where a workflow without an error wouldn't render properly because we didn't have undefined guards (introduced in #1107, I think?).

Related issue number (if any)

ENG-2645

Loom demo (if any)

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • [N/A] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • [N/A] If this is a new feature, I have added unit tests and integration tests.
  • [N/A] I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@vsreekanti vsreekanti added the skip_integration_test Skips required integration test (only documentation/UI changes) label Mar 20, 2023
Copy link
Contributor

@agiron123 agiron123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this also fixes the issue where the no_run workflow crashed the app!

image

@vsreekanti vsreekanti merged commit 5a5b306 into main Mar 20, 2023
@vsreekanti vsreekanti deleted the eng-2645-next-run-button-broken-on-ui branch March 20, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants