Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG 2494 Fix a bug where metric graph dates are cutted off #1048

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

likawind
Copy link
Contributor

@likawind likawind commented Mar 3, 2023

Describe your changes and why you are making these changes

This PR improves the magin of metric plots so that x-axes will not be cut off.

Related issue number (if any)

ENG 2494

Loom demo (if any)

Screenshot 2023-03-03 at 3 54 10 PM
Screenshot 2023-03-03 at 3 54 22 PM

Checklist before requesting a review

  • I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
  • I have performed a self-review of my code.
  • I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
  • If this is a new feature, I have added unit tests and integration tests.
  • I have run the integration tests locally and they are passing.
  • I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
  • All features on the UI continue to work correctly.
  • Added one of the following CI labels:
    • run_integration_test: Runs integration tests
    • skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

Copy link
Contributor

@agiron123 agiron123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Love the diagonal dates here! Didn't know you could do this.

@likawind
Copy link
Contributor Author

likawind commented Mar 6, 2023

@agiron123 actually I know it as it's mentioned in the bug report :)

@likawind likawind added the skip_integration_test Skips required integration test (only documentation/UI changes) label Mar 7, 2023
@likawind likawind merged commit 8c450e8 into main Mar 7, 2023
@vsreekanti vsreekanti deleted the eng-2494-fix-bug-where-metric-graph-dates-are-cut branch March 7, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip_integration_test Skips required integration test (only documentation/UI changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants