ENH: CP and Thrust Eccentricity Effects Generate Roll Moment

[MateusStano]

Pull request type

• Code changes (bugfix, features)

Checklist

• Tests for the changes have been added (if needed)
• Docs have been reviewed and added / updated
• Lint (black rocketpy/ tests/) has passed locally
• All tests (pytest tests -m slow --runslow) have passed locally
• CHANGELOG.md has been updated (if relevant)

Current behavior

CP eccentricities did not generate moment on the rocket's center axis (roll moment M3) and thrust eccentricity was not included in u_dot_generalized

New behavior

Roll moment is calculated properly and thrust eccentricity is included in u_dot_generalized

Breaking change

• Yes
• No

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.60%. Comparing base (158d1ca) to head (6af67ac).
Report is 1 commits behind head on develop.

❗ Current head 6af67ac differs from pull request most recent head 240585b

Please upload reports for the commit 240585b to get more accurate results.

Files	Patch %	Lines
rocketpy/simulation/flight.py	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #617      +/-   ##
===========================================
- Coverage    73.60%   73.60%   -0.01%     
===========================================
  Files           70       70              
  Lines        10290    10292       +2     
===========================================
+ Hits          7574     7575       +1     
- Misses        2716     2717       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Gui-FernandesBR]

Send like r1 and r2 are aligned to the global coordinate system (the earth) but the x and y excentricity should be aligned to the local (rocket) coordinate system.

Right now I understand you are assuming R1 is always parallel to x_excentricity, right?

[Gui-FernandesBR]

Please update the CHANGELOG

[MateusStano]

Send like r1 and r2 are aligned to the global coordinate system (the earth) but the x and y excentricity should be aligned to the local (rocket) coordinate system.

Right now I understand you are assuming R1 is always parallel to x_excentricity, right?

R1, R2, and R3 are described in the rocket coordinate system from what I understand

What I did here is in accordance with what the code was doing before, I am not assuming anything different. But yes, I believe the R1 was assumed to be parallel to x