Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Final refactor before v1.2 #553

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

Gui-FernandesBR
Copy link
Member

Pull request type

  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates

Checklist

  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Some comments made in the #536 PR conversation.

New behavior

Read the commit messages one by one.

Breaking change

  • No

Additional information

@Gui-FernandesBR Gui-FernandesBR added the Docs Docs and examples related label Feb 12, 2024
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Feb 12, 2024
@Gui-FernandesBR Gui-FernandesBR self-assigned this Feb 12, 2024
@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner February 12, 2024 07:08
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4e67f4) 72.47% compared to head (1d819d1) 72.47%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #553   +/-   ##
========================================
  Coverage    72.47%   72.47%           
========================================
  Files           59       59           
  Lines         9566     9567    +1     
========================================
+ Hits          6933     6934    +1     
  Misses        2633     2633           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR merged commit 9da1542 into develop Feb 12, 2024
12 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the mnt/final-refactor-before-v1.2 branch February 12, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related Refactor
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants