Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Update interpolation method in linearly_interpolated_func #504

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Gui-FernandesBR
Copy link
Member

linearly_interpolated_func

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

I found this bug on a pytest fixture.

New behavior

The linearly_interpolated_func fixture is now using the linear interpolation method
Updated the docstring as well.

Breaking change

  • Yes
  • No

Additional information

the tests are passing even if adter the change

linearly_interpolated_func
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13204ce) 71.17% compared to head (9b9f7b5) 71.17%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #504   +/-   ##
========================================
  Coverage    71.17%   71.17%           
========================================
  Files           55       55           
  Lines         9277     9277           
========================================
  Hits          6603     6603           
  Misses        2674     2674           
Flag Coverage Δ
unittests 71.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR changed the title MNT: Update interpolation method in MNT: Update interpolation method in linearly_interpolated_func Dec 7, 2023
@Gui-FernandesBR Gui-FernandesBR merged commit 2751568 into develop Dec 7, 2023
14 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the tst/fix-linearly_interpolated_func branch December 7, 2023 21:15
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants