Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Misplaced language dropdown in user preferences panel #9883

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Regression: Misplaced language dropdown in user preferences panel #9883

merged 1 commit into from
Feb 27, 2018

Conversation

kaiiiiiiiii
Copy link
Contributor

@kaiiiiiiiii kaiiiiiiiii commented Feb 24, 2018

@RocketChat/core

Closes #9882

Looks like all the other dropdowns in Rocket.Chat again :)

Before:
screen shot 2018-02-24 at 09 38 29

After:
screen shot 2018-02-24 at 10 59 49

…ent because all the other dropdowns in Rocket.Chat work like that.
@rodrigok rodrigok added this to the 0.62.0 milestone Feb 24, 2018
@rodrigok rodrigok requested a review from a team February 26, 2018 17:21
@rodrigok rodrigok changed the title [FIX] Misplaced language dropdown in user preferences panel Regression: Misplaced language dropdown in user preferences panel Feb 26, 2018
@karlprieb
Copy link
Contributor

You can set width: 100% to .rc-select__element and the select will look like this:

image

@kaiiiiiiiii
Copy link
Contributor Author

kaiiiiiiiii commented Feb 26, 2018

@karlprieb but is it supposed to look different from all the other dropdowns in the user preferences ui?

screen shot 2018-02-26 at 21 28 13

@karlprieb
Copy link
Contributor

@kaiiiiiiiii no, the other ones are wrong. We didn't updated this page. You can fix that if you want changing all selects to be equal to the language selector.

@kaiiiiiiiii
Copy link
Contributor Author

kaiiiiiiiii commented Feb 26, 2018

@karlprieb As far as I can see there's only one other dropdown which is tagged with the rc-select__element class.

Anyway, can you may approve this PR to get a working solution for release 0.62.0 (same look as in 0.61.2) and I'll open another PR which changes all dropdowns in RC? Because there's also a 2px cut off at the bottom, which needs to be fixed first.

screen shot 2018-02-26 at 22 45 25

@karlprieb
Copy link
Contributor

@kaiiiiiiiii Sure!

@rodrigok rodrigok merged commit d26ced2 into RocketChat:develop Feb 27, 2018
@kaiiiiiiiii kaiiiiiiiii deleted the fix_misplaced_language_dropdown_in_user_preferences_panel branch February 27, 2018 16:14
@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants