Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] New sidebar layout #9608

Merged
merged 37 commits into from
Feb 21, 2018
Merged

[NEW] New sidebar layout #9608

merged 37 commits into from
Feb 21, 2018

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 6, 2018 •
edited by rodrigok
Loading

image
image
image

@RocketChat/core

Close #9541

closes #9224

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9608 February 6, 2018 13:07 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9608 February 6, 2018 13:59 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-9608 February 6, 2018 14:06 Inactive
@sampaiodiego
Copy link
Member

screenshots pls

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9608 February 6, 2018 18:09 Inactive
@ggazzo
Copy link
Member Author

ggazzo commented Feb 6, 2018

@sampaiodiego
flw3jipl3c

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9608 February 6, 2018 19:12 Inactive
@engelgabriel engelgabriel mentioned this pull request Feb 6, 2018
Closed
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9608 February 7, 2018 15:57 Inactive
@RocketChat RocketChat deleted a comment Feb 7, 2018
ggazzo
ggazzo commented Feb 20, 2018
View reviewed changes
packages/rocketchat-theme/client/imports/components/sidebar/sidebar-item.css Outdated
@@ -142,7 +142,7 @@
width: var(--sidebar-item-user-status-size);
height: var(--sidebar-item-user-status-size);

margin: 0 7px 0 3px;
margin: 0 7px 0 7px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

margin: 0 7px;

packages/rocketchat-theme/client/imports/general/base.css
@@ -118,7 +118,7 @@ button {
.rc-icon {
overflow: hidden;

width: 1em;
width: 1.25em;
Copy link
Member Author

@ggazzo ggazzo Feb 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? width and height should be equal

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9608 February 20, 2018 18:50 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9608 February 20, 2018 18:53 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9608 February 20, 2018 18:55 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9608 February 20, 2018 19:14 Inactive
@karlprieb
Copy link
Contributor

@sampaiodiego

image

image

image

and fixed search bar too :)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9608 February 20, 2018 22:12 Inactive
@rodrigok rodrigok added this to the 0.62.0 milestone Feb 20, 2018
@rodrigok rodrigok changed the title New sidebar [NEW] New sidebar layout Feb 21, 2018
@rodrigok rodrigok merged commit 41bffea into develop Feb 21, 2018
@rodrigok rodrigok deleted the new-sidebar branch February 21, 2018 00:23
@johnyb0y
Copy link

johnyb0y commented Feb 26, 2018 •
edited
Loading

@ggazzo I really like the changes. For admins with less tech-savvy users there's a problem though:
I rolled out 0.62.0-rc2 on our test server and the sidebar layout of existing users changed significantly.
It would be great if the standard layout of the new sidebar with its configurable options could be close to the look of older versions.
Or even better: if you could roll out a editable standard setting for every user via the admin panel.
Thanks for your great work!

@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Merged
@TheReal1604 TheReal1604 mentioned this pull request Feb 28, 2018
Closed
@reza899
Copy link

reza899 commented Mar 6, 2018 •
edited
Loading

in RTL language (farsi in my case) the menu for user not apear correctly.
capture

in "my account" section, it may not work save changes. after chaning some option, it is not saved.

@karlprieb
Copy link
Contributor

Thank you @reza899 for your report, can you open an issue for that?

@reza899
Copy link

reza899 commented Mar 7, 2018 •
edited
Loading

yes, I was opened it at #10018

@eniris
Copy link

eniris commented Mar 29, 2018 •
edited
Loading

Hi @karlprieb I can't see the extended link in view mode list.
Is there a setting ?
image
-edit-
I found it !
image
in general settings ;)

@karlprieb
Copy link
Contributor

@eniris Great! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlprieb karlprieb karlprieb left review comments

@gdelavald gdelavald gdelavald approved these changes

@sampaiodiego sampaiodiego sampaiodiego left review comments

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.62.0
Development

Successfully merging this pull request may close these issues.

New sidebar header and views Beautify status icon in user list