Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] "Enter usernames" placeholder is cutting in "create channel" view #9194

Merged
merged 2 commits into from
Dec 21, 2017
Merged

[FIX] "Enter usernames" placeholder is cutting in "create channel" view #9194

merged 2 commits into from
Dec 21, 2017

Conversation

TheReal1604
Copy link
Contributor

@RocketChat/core

Closes #8785

before:
bildschirmfoto 2017-12-19 um 23 14 52

after:
bildschirmfoto 2017-12-20 um 00 07 18

@rodrigok
Copy link
Member

Idk if it's the best solution for it. It will break the input to the second line as soon we add a new tag/user.

@karlprieb thoughts?

@TheReal1604
Copy link
Contributor Author

@rodrigok with 70% it breaks at the second username and it is displayed correctly..

@rodrigok rodrigok requested a review from ggazzo December 20, 2017 15:54
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9194 December 20, 2017 16:02 Inactive
@ggazzo
Copy link
Member

ggazzo commented Dec 20, 2017

@TheReal1604 flex:1 doesn't solve your problem?

@rodrigok rodrigok changed the title [FIX]Fix spacing from enter username field in create new channel menu [FIX] "Enter usernames" placeholder is cutting in "create channel" view Dec 20, 2017
@TheReal1604
Copy link
Contributor Author

@ggazzo flex:1 seems to fix it at the first view.. BUT.. you get this after entering usernames (also cutted at the end):

bildschirmfoto 2017-12-20 um 20 55 21

@rodrigok
Copy link
Member

@TheReal1604 but it's better than create a new line after first tag or cut the placeholder at the beginning don't you think?

@TheReal1604
Copy link
Contributor Author

@rodrigok For me as a user it looks really unpolished and broken if something gets cutted. :/

I think a better way is to hide the description of the field if a username is selected. This should look consistent. What you think?

@rodrigok
Copy link
Member

@karlprieb what do you think 🔝

@karlprieb
Copy link
Contributor

@TheReal1604 @rodrigok I agree, we can use flex: 1 to fix the "placeholder" width and when the first user is added we can hide/remove the placeholder.

@TheReal1604
Copy link
Contributor Author

TheReal1604 commented Dec 20, 2017

That sounds awesome! @karlprieb I have unfortunately no idea how to do the hiding thing. I correct the pull request to flex:1. Can you take a look? (Or give me an idea how to do it?) ;-)

@karlprieb
Copy link
Contributor

@TheReal1604 Yep, I'll take a look! :)

@rodrigok
Copy link
Member

@ggazzo meanwhile I'll merge this PR cuz it improves the current behavior.

@rodrigok rodrigok merged commit 981c366 into RocketChat:develop Dec 21, 2017
@rodrigok rodrigok added this to the 0.60.0 milestone Dec 21, 2017
rodrigok added a commit that referenced this pull request Dec 26, 2017
[FIX] "Enter usernames" placeholder is cutting in "create channel" view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants