Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Rest API endpoints to list, get, and run commands #8531

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

graywolf336
Copy link
Contributor

Also, includes a nice client utility to use the rest api.

RocketChat.API.v1.get('info').then((result) => console.log(result));

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8531 October 18, 2017 21:33 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8531 October 30, 2017 19:05 Inactive
@graywolf336
Copy link
Contributor Author

@rodrigok status update on this? We talked about this pull request two Fridays ago but I've yet to hear anything regarding this.

Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekgonecrazy geekgonecrazy added this to the 0.60.0 milestone Nov 14, 2017
@rafaelks
Copy link
Contributor

We need to merge this one guys.

@geekgonecrazy
Copy link
Contributor

Looks solid to me. Not going to break anything and works as intended will help out mobile guys.

Merging 👍

@cardoso
Copy link
Contributor

cardoso commented Nov 27, 2017

@RocketChat/core do we also have a Real-Time method to get the changes?

@sampaiodiego
Copy link
Member

@cardoso by changes you mean like new commands? since there is no way to add new commands at run time (at least before rocket.chat apps go live), there is no need for such real-time updates.

@graywolf336
Copy link
Contributor Author

@cardoso now that rocket.chat apps is merged there is a real time listener to listen for updates of commands, although that only is enabled if the rocket.chat apps system is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants