-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Remove sidebar header on admin embedded version #8334
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,15 @@ | ||
<template name="accountFlex"> | ||
<aside class="sidebar-light" role="navigation"> | ||
<header class="sidebar__header"> | ||
{{> accountBox lighten=true modifier="--account" }} | ||
<button class="sidebar-flex__back-button" data-action="back"> | ||
{{> icon block="sidebar-flex__back-icon" icon="back"}} | ||
<span>{{_ "Back_to_chat"}}</span> | ||
</button> | ||
</header> | ||
<div class="rooms-list"> | ||
{{#unless embeddedVersion}} | ||
<header class="sidebar__header"> | ||
{{> accountBox lighten=true modifier="--account" }} | ||
<button class="sidebar-flex__back-button" data-action="back"> | ||
{{> icon block="sidebar-flex__back-icon" icon="back"}} | ||
<span>{{_ "Back_to_chat"}}</span> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change "Back_to_chat" to just "Back" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why? |
||
</button> | ||
</header> | ||
{{/unless}} | ||
<div class="rooms-list {{#if embeddedVersion}}rooms-list--embedded{{/if}}"> | ||
<ul class="rooms-list__list"> | ||
{{> sidebarItem menuItem "Preferences" "customize" "account" "preferences" }} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,15 @@ | ||
<template name="adminFlex"> | ||
<aside class="sidebar-light" role="navigation"> | ||
<header class="sidebar__header"> | ||
{{> accountBox lighten=true modifier="--admin"}} | ||
<button class="sidebar-flex__back-button" data-action="back"> | ||
{{> icon block="sidebar-flex__back-icon" icon="back"}} | ||
<span>{{_ "Back_to_chat"}}</span> | ||
</button> | ||
</header> | ||
<div class="rooms-list" aria-label="{{_ "Administration"}}"> | ||
{{#unless embeddedVersion}} | ||
<header class="sidebar__header"> | ||
{{> accountBox lighten=true modifier="--admin"}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also remove this account box There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can remove that, but I won't do that on this PR. This PR is about embedded view and not about accountBox. |
||
<button class="sidebar-flex__back-button" data-action="back"> | ||
{{> icon block="sidebar-flex__back-icon" icon="back"}} | ||
<span>{{_ "Back_to_chat"}}</span> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change "Back_to_chat" to just "Back" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Less is More There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok, it's easy to maintain translations :) |
||
</button> | ||
</header> | ||
{{/unless}} | ||
<div class="rooms-list {{#if embeddedVersion}}rooms-list--embedded{{/if}}" aria-label="{{_ "Administration"}}"> | ||
<h3 class="rooms-list__type">{{_ "Administration"}}</h3> | ||
<ul class="rooms-list__list"> | ||
{{> sidebarItem menuItem "Info" false "admin-info" "" }} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this account box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove that, but I won't do that on this PR. This PR is about embedded view and not about accountBox.