Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dropdown for message options #829

Closed
wants to merge 3 commits into from

Conversation

geekgonecrazy
Copy link
Contributor

Behavior could probably use some tweaking. Thoughts @RocketChat/owners?

image

image

Related to: #828 and #310

@geekgonecrazy
Copy link
Contributor Author

Hold on this. May close it out. @rodrigok has something he was trying out that looked much cooler. :)

@rodrigok
Copy link
Member

@geekgonecrazy done :)

set 18 2015 12 12

@geekgonecrazy
Copy link
Contributor Author

nice! 👍

@graywolf336
Copy link
Contributor

Is that on hover or on click? Looks like on click, wonder how it would work with on hover..

@sampaiodiego
Copy link
Member

I think you should not be able to open two dropdowns.. I mean, if you click outside the opened dropdown, it should close.

what you guys mean?

@rockneverdies55
Copy link

I think you should not be able to open two dropdowns.. I mean, if you click outside the opened dropdown, it should close.

👍

@geekgonecrazy
Copy link
Contributor Author

Is that on hover or on click? Looks like on click, wonder how it would work with on hover..

Would that get tricky to actually click on one of them? We can try it

I think you should not be able to open two dropdowns.. I mean, if you click outside the opened dropdown, it should close.

I agree. Clicking outside should close it, and it can get messy with multiple up.

@graywolf336
Copy link
Contributor

Yes I agree, there should be a max of only one opened up at a time.

I'm wondering if it should show up on hovering instead of clicking on the cog? That way it's one less click?

@rodrigok
Copy link
Member

@graywolf336, can be on hover, but hover don't work for mobile.

@graywolf336
Copy link
Contributor

@rodrigok I would think mobile you would tap and hold the message to bring up a list of actions on the message, like the report abuse way is.

@geekgonecrazy
Copy link
Contributor Author

See f60eadc

@geekgonecrazy geekgonecrazy deleted the message-action-dropdown branch September 18, 2015 20:00
@rodrigok
Copy link
Member

@graywolf336 I'm thinking something more like this on tap:

image

@rockneverdies55
Copy link

@rodrigok - This really looks cool.

👍

@graywolf336
Copy link
Contributor

@rodrigok Oh yeah that'll work too 👍

Shailesh351 pushed a commit to Shailesh351/Rocket.Chat that referenced this pull request Aug 17, 2021
Change log level of gettranscript from debug to error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants