Fix leave and hide click, color and position
#8243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
requested changes
Sep 21, 2017
| @@ -9,7 +9,7 @@ <h3 class="rc-popover__title">{{group.title}}</h3> | |||
| {{/if}} | |||
| <ul class="rc-popover__list"> | |||
| {{#each item in group.items}} | |||
| <li class="rc-popover__item rc-popover__item--{{item.class}}" data-type={{item.type}} data-id={{item.id.toLowerCase}} data-href={{item.href}} data-sidenav={{item.sideNav}}> | |||
| <li class="rc-popover__item rc-popover__item--{{item.modifier}}" data-type={{item.type}} data-id={{item.id.toLowerCase}} data-href={{item.href}} data-sidenav={{item.sideNav}}> | |||
There was a problem hiding this comment.
whats happen when the modifier is null?
There was a problem hiding this comment.
It will create an rc-popover__item-- class. Is it a problem?
ggazzo
approved these changes
Sep 21, 2017
rodrigok
changed the title
leave and hide click, color and position
rodrigok
added a commit
that referenced
this pull request
Sep 23, 2017
Fix `leave and hide` click, color and position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #ISSUE_NUMBER