[MOVE] Move favico to client folder #8077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as in RocketChat#6046, we should move files to a client folder
|
I disabled eslint for this file as it was throwing a lot of errors, it that is a problem we can create another PR for fixing these errors |
|
@vcapretz you can leave eslint on in this, it's useful for tracking future changes. If you want to refactor this I wouldn't mind also :) |
|
@gdelavald as we talked sooner, it's an external lib so I'm going to open a PR in the author's repository and keep the linting ignore here, so it won't throw errors when building! |
gdelavald
approved these changes
Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as in #6046, we should move files to a client folder
@RocketChat/core