Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Error when translating message #8001

Merged
merged 1 commit into from
Sep 2, 2017
Merged

[FIX] Error when translating message #8001

merged 1 commit into from
Sep 2, 2017

Conversation

rodrigok
Copy link
Member

@RocketChat/core

Fix exception:

TypeError: Cannot read property 'length' of undefined
  at AutoTranslate.tokenizeURLs (/app/bundle/programs/server/packages/rocketchat_autotranslate.js:118:30)
  at AutoTranslate.tokenize (/app/bundle/programs/server/packages/rocketchat_autotranslate.js:83:19)
  at /app/bundle/programs/server/packages/rocketchat_autotranslate.js:277:30
  at [object Object].EVp.withValue (packages/meteor.js:1135:15)
  at packages/meteor.js:452:25
  at runWithEnvironment (packages/meteor.js:1189:24)

@rodrigok rodrigok added this to the 0.59.0-rc.4 milestone Aug 31, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8001 August 31, 2017 14:33 Inactive
@engelgabriel engelgabriel merged commit c4ac5ad into develop Sep 2, 2017
@engelgabriel engelgabriel deleted the hotfix/autotranslate-parse-error branch September 2, 2017 19:38
@rodrigok rodrigok mentioned this pull request Sep 5, 2017
Merged
rodrigok pushed a commit that referenced this pull request Sep 5, 2017
@engelgabriel @rodrigok
Merge pull request #8001 from RocketChat/hotfix/autotranslate-parse-e…
6016e05 
…rror

[FIX] Error when translating message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlprieb karlprieb karlprieb approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.59.0-rc.4
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigok @karlprieb @engelgabriel