Adding support for private groups reopening and fixing room subscription state #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gmsecrieru
commented
Sep 11, 2015
gmsecrieru
commented
- Added a list of Private Groups allowing users to reopen closed Groups (i.e. reproducing behavior from Channels list)
- Bug fix: When a given room is closed and reopened, the user's room subscription "open" state was not being updated to "true", thus the room was not showing in the SideNav list.
- Adding Private Groups list ("More groups")
- Bug fixed: rocketchat_subscription "open" flag is now updated when user reopens a given room
Conflicts: i18n/en.i18n.json
| @@ -48,6 +48,8 @@ openRoom = (type, name) -> | |||
| $('.message-form .input-message').focus() | |||
| , 100 | |||
|
|
|||
| # update user's room subscription | |||
| Meteor.call 'openRoom', room._id | |||
There was a problem hiding this comment.
Update subscription every time user enter in a room’s route don't seems to be a good idea.
There was a problem hiding this comment.
@rodrigok what about this?
# update user's room subscription
if ChatSubscription.findOne({rid: room._id})?.open is false
Meteor.call 'openRoom', room._id
There was a problem hiding this comment.
@marceloschmidt looks good, but already was merged 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.