Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Sidenav roomlist #7023

Merged
merged 6 commits into from
May 19, 2017
Merged

[FIX] Sidenav roomlist #7023

merged 6 commits into from
May 19, 2017

Conversation

karlprieb
Copy link
Contributor

@RocketChat/core

Removed all unnecessary templates to group rooms and created one template to deal with all types of group.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7023 May 18, 2017 21:22 Inactive
sampaiodiego
sampaiodiego requested changes May 19, 2017
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using non-merged channels ("My Account > Preferences > Merge private groups with channels" set to false) the under "Private groups" is showing "more channels" instead of "more private groups"

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7023 May 19, 2017 17:16 Inactive
sampaiodiego
sampaiodiego requested changes May 19, 2017
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When allowing anonymous read (Administration > Accounts > Allow anonymous read) it does not show channels on the list

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7023 May 19, 2017 18:10 Inactive
@karlprieb
Copy link
Contributor Author

Thanks @sampaiodiego
I already fixed this problems :)

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-7023 May 19, 2017 19:05 Inactive
@karlprieb karlprieb merged commit 61a7c63 into develop May 19, 2017
@sampaiodiego sampaiodiego deleted the sidenav-roomlist branch May 25, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karlprieb @sampaiodiego @engelgabriel