Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix login with Meteor saving an object as email address #6974

Merged
merged 1 commit into from
May 16, 2017

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented May 15, 2017

@RocketChat/core

We were saving an object for emails.address user's property for Meteor's OAuth as shown bellow:

{
    "_id" : "fAkeId",
    "type" : "user",
    "name" : "fakename",
    "emails" : [ 
        {
            "address" : {
                "address" : "fakename@meteoroauth.com",
                "verified" : true,
                "primary" : true
            },
            "verified" : true
        }
    ],
    "roles" : [ 
        "user"
    ]
}

This PR is to get only the primary email address from Meteor's OAuth and also fixes problems related to getUsernameSuggestion because address property was not a string.

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6974 May 15, 2017 12:56 Inactive
@rodrigok rodrigok merged commit 5bf5c58 into develop May 16, 2017
@rodrigok rodrigok deleted the fix-login-by-meteor-emails branch May 16, 2017 14:40
@rodrigok rodrigok added this to the 0.57.0 milestone May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants