Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fix error handling for non-valid avatar URL #6972

Merged
merged 2 commits into from
May 17, 2017
Merged

[FIX] Fix error handling for non-valid avatar URL #6972

merged 2 commits into from
May 17, 2017

Conversation

sampaiodiego
Copy link
Member

@RocketChat/core

When given an invalid URL for an avatar it was given the following error on server console:

TypeError: Cannot read property 'statusCode' of undefined

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6972 May 15, 2017 12:12 Inactive
@sampaiodiego sampaiodiego changed the title Fix error handling for non-valid avatar URL [FIX] Fix error handling for non-valid avatar URL May 15, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6972 May 17, 2017 13:52 Inactive
@rodrigok rodrigok added this to the 0.57.0 milestone May 17, 2017
@rodrigok rodrigok merged commit c7d11b6 into develop May 17, 2017
@rodrigok rodrigok deleted the fix-avatar-from-invalid-url branch May 17, 2017 14:17
@TwizzyDizzy TwizzyDizzy mentioned this pull request Sep 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.57.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sampaiodiego @rodrigok @engelgabriel