Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Not showing unread count on electron app’s icon #6923

Merged
merged 1 commit into from
May 9, 2017
Merged

[FIX] Not showing unread count on electron app’s icon #6923

merged 1 commit into from
May 9, 2017

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented May 9, 2017 •
edited by engelgabriel
Loading

@RocketChat/core

Close #6900

@rodrigok rodrigok added this to the 0.56.0 milestone May 9, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6923 May 9, 2017 18:35 Inactive
@sampaiodiego
Copy link
Member

sampaiodiego commented May 9, 2017 •
edited
Loading

should we add a comment on that line describing what it does so people like me don't mess with it again? 😬

@sampaiodiego sampaiodiego reopened this May 9, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6923 May 9, 2017 18:39 Inactive
@engelgabriel engelgabriel merged commit 48efadb into release-candidate May 9, 2017
@engelgabriel engelgabriel deleted the hotfix/rc-electron-unread-badge branch May 9, 2017 19:08
@engelgabriel engelgabriel mentioned this pull request May 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.56.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigok @sampaiodiego @engelgabriel