[NEW] Feature/delete any message permission

[phutchins]

@RocketChat/core

This addresses: #4921

Summary

This adds an option called delete-any-message (maybe we should rename), which by default allows admins and owners to delete any message overriding the time window for deletion.

Solves...

The problem that this solves is when you have Block Message Deleting After (n) Minutes turned on, once that timeframe has expired, even admins and owners cannot delete messages without temporarily turning this setting off.

Considerations

Setting Name

Currently the setting is named delete-any-message but I've considered something like message-delete-block-override and am open to suggestions...

Permission Retrieval

I'm using hasAtLeastOnePermisison, with one permisison, to find the permission and do the conditionals. I would have liked to use hasPermission with an array containing delete-any-message and delete-message but with the way that the blockDeleteInMinutes is structured, it proved difficult so I've left it this way. It works fine this way but I'm open to suggestions on how to handle this if there are better ideas.

Tests

Tests are passing...

I've not written any tests to cover this yet. There may be tests that cover this mostly but wanted input before writing any tests. Suggestions welcome.

[CLAassistant]

All committers have signed the CLA.

[marceloschmidt]

I'd probably rename delete-any-message to force-delete-message but all the rest is looking good.

[phutchins]

Thanks @marceloschmidt!

[phutchins]

@marceloschmidt our of curiousity, whats the merge release frequency/schedule look like for this?

[marceloschmidt]

Ah, that's a tough question :( let me see if I can speed it up.