[NEW] create a method 'create token' #6807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
requested review from
rodrigok and
graywolf336
and removed request for
rodrigok
graywolf336
suggested changes
Apr 26, 2017
| @@ -0,0 +1,13 @@ | |||
| Meteor.methods({ | |||
| createToken({user}) { | |||
There was a problem hiding this comment.
Change this parameter to only show which properties of the user you need. This way the clients calling this real-time method don't need to pass the full user object which in turn makes transmission over the wire faster.
|
@graywolf336 I think @rodrigok have a better answer. But I believe the case is a service/integration that uses the API, but we don't want to save passwords to get the token. |
graywolf336
approved these changes
Apr 26, 2017
|
Okay. We've had a lot of people expecting the login via the rest api actually logging them into the website, which is why I was asking |
|
@RocketChat/core this is a huge security flaw! How's this been approved? So an admin can now create a token for any user and login as them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Allowed users (usually admins) can generate access tokens to another user.
Users can generate theirs tokens too.