Convert Message-Star Package to js #6781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
requested changes
Apr 27, 2017
| @@ -0,0 +1,69 @@ | |||
| /*globals StarredMessage */ | |||
There was a problem hiding this comment.
I can't find the coffee version of this file
There was a problem hiding this comment.
There was a problem hiding this comment.
Can you delete the file in your commit? Or do you want to keep the old .coffee file?
| @@ -0,0 +1,33 @@ | |||
| Meteor.publish('starredMessages', function(rid, limit) { | |||
| if (limit == null) { | |||
rodrigok
requested changes
Apr 27, 2017
| this.hasMore = new ReactiveVar(true); | ||
| this.limit = new ReactiveVar(50); | ||
| return this.autorun(() => { | ||
| return () => { |
There was a problem hiding this comment.
Why this function? It'll never be called
| return () => { | ||
| const sub = this.subscribe('starredMessages', this.data.rid, this.limit.get()); | ||
| if (sub.ready()) { | ||
| if (StarredMessage.find({ |
There was a problem hiding this comment.
Do not break the if, move the find to a variable
rodrigok
approved these changes
Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core