Convert Oembed Package to Js #6688
Conversation
| if (this.collapsed) { | ||
| return this.collapsed; | ||
| } else { | ||
| return (user && user.settings && user.settings.preferences && user.settings.preferences.collapseMediaByDefault); |
There was a problem hiding this comment.
You can move the variable declaration here. And there is no need for the parenthesis
| if (this.collapsed) { | ||
| return this.collapsed; | ||
| } else { | ||
| return (user && user.settings && user.settings.preferences && user.settings.preferences.collapseMediaByDefault) === true; |
| loadImage() { | ||
| const user = Meteor.user(); | ||
|
|
||
| if (user && user.settings && user.settings.preferences && user.settings.preferences.autoImageLoad === false && this.downloadImages) { |
There was a problem hiding this comment.
I guess the correct condition here is this.downloadImages == null
| if (user && user.settings && user.settings.preferences && user.settings.preferences.autoImageLoad === false && this.downloadImages) { | ||
| return false; | ||
| } | ||
| if (Meteor.Device.isPhone() && user() && user.settings && user.settings.preferences && user.settings.preferences.saveMobileBandwidth && this.downloadImages) { |
There was a problem hiding this comment.
User is not a function here, you already called the function to get the data. The correct condition for downloadImage is this.downloadImages == null
| if (this.collapsed != null) { | ||
| return this.collapsed; | ||
| } else { | ||
| return (user && user.settings && user.settings.preferences && user.settings.preferences.collapseMediaByDefault) === true; |
There was a problem hiding this comment.
Move the declaration here and remove the parenthesis
| if (this.collapsed != null) { | ||
| return this.collapsed; | ||
| } else { | ||
| return (user && user.settings && user.settings.preferences && user.settings.preferences.collapseMediaByDefault) === true; |
There was a problem hiding this comment.
Move the declaration here and remove the parenthesis
| if (this.collapsed) { | ||
| return this.collapsed; | ||
| } else { | ||
| return (user && user.settings && user.settings.preferences && user.settings.preferences.collapseMediaByDefault) === true; |
| if (this.collapsed) { | ||
| return this.collapsed; | ||
| } else { | ||
| return (user && user.settings && user.settings.preferences && user.settings.preferences.collapseMediaByDefault) === true; |
| }; | ||
|
|
||
| const getUrlContent = function(urlObj, redirectCount, callback) { | ||
| if (redirectCount == null) { |
| }); | ||
| } | ||
| if (content && content.statusCode !== 200) { | ||
| return; |
There was a problem hiding this comment.
Did you forget to return the data? return data;
There was a problem hiding this comment.
@rodrigok But here data would just return undefined since the variable is being created just after that return, or did i miss something here?
|
@rodrigok could you do another review? |
@RocketChat/core Please let me know if i something is wrong, since this is a fairly big package.