Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Allow question on OAuth token path #6684

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

sampaiodiego
Copy link
Member

@RocketChat/core

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-6684 April 13, 2017 17:47 Inactive
@rodrigok rodrigok added this to the 0.55.0 milestone Apr 13, 2017
@engelgabriel engelgabriel merged commit 5b2ad03 into develop Apr 13, 2017
@engelgabriel engelgabriel deleted the allow-question-mark-on-oauth-token-path branch April 13, 2017 18:12
@wargamesqcf
Copy link

wargamesqcf commented Apr 21, 2017

Tried method 1 and method 2 got this as an error, also using verison 3.2002 of WP Oauth server, and 55.1 of rocketchat
{"error":"invalid_client","error_description":"The client id supplied is invalid"}

My settings
http://i.imgur.com/gRlkOwe.png?1

From my logs I get this error

�[34mW20170421-02:18:26.645(0) (oauth.js:431) �[35mError in OAuth Server: Failed to fetch identity from wordpress at http://www.five-rings-online.net?oauth=me. Unexpected token <
�[34mI20170421-02:18:27.835(0) Exception while invoking method 'login' Error: Failed to fetch identity from wordpress at http://www.five-rings-online.net?oauth=me. Unexpected token < at CustomOAuth.getIdentity (/app/bundle/programs/server/packages/rocketchat_custom-oauth.js:206:17) at Object.handleOauthRequest (/app/bundle/programs/server/packages/rocketchat_custom-oauth.js:222:25) at OAuth._requestHandlers.(anonymous function) (packages/oauth2.js:27:31) at middleware (packages/oauth.js:203:5) at packages/oauth.js:176:5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants