Convert Ui-Login Package to Js #6561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
requested changes
Apr 1, 2017
| if (customFields[field]) { | ||
| const customField = customFields[field]; | ||
| if (customField.required === true && !value) { | ||
| return validationObj[field] = t('Field_required'); |
There was a problem hiding this comment.
This return should return to function validateCustomFields
|
|
||
| Template.loginServices.events({ | ||
| 'click .external-login'(e) { | ||
| if (this.service && this.service.service == null) { |
There was a problem hiding this comment.
if (this.service == null || this.service.service == null) {
rodrigok
requested changes
Apr 3, 2017
| for (const field in formObj) { | ||
| if (formObj.hasOwnProperty(field)) { | ||
| const value = formObj[field]; | ||
| if (customFields[field]) { |
There was a problem hiding this comment.
I guess you inverted this condition, the correct is if (customFields[field] == null) {
rodrigok
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core