[New] Added oauth2 userinfo endpoint #6554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
requested changes
Mar 31, 2017
|
|
||
| accessToken = req.headers.authorization.replace('Bearer ', '') | ||
|
|
||
| token = oauth2server.oauth.model.AccessTokens.findOne accessToken: accessToken |
There was a problem hiding this comment.
The idea is return an exception if the token was not found?
There was a problem hiding this comment.
Added checks on this and the user.
|
|
||
| token = oauth2server.oauth.model.AccessTokens.findOne accessToken: accessToken | ||
|
|
||
| user = RocketChat.models.Users.findOneById(token.userId); |
There was a problem hiding this comment.
Added a check here as well
rodrigok
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Added as per part of the spec: https://connect2id.com/products/server/docs/api/userinfo
Ran into an application that needed this on the server to finish the oauth login process. Since its part of the spec, I went ahead and added it.