-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
converted Rocketchat logger coffee to js #6495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto rocketchat-logger
ggazzo
force-pushed
the
rocketchat-logger
branch
from
March 28, 2017 03:31
a5a9f17
to
487bbf2
Compare
rodrigok
requested changes
Mar 29, 2017
@@ -17,12 +17,14 @@ Package.onUse(function(api) { | |||
api.use('kadira:flow-router', 'client'); | |||
|
|||
api.addFiles('ansispan.js', 'client'); | |||
api.addFiles('logger.coffee', 'client'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the coffeescript package
packages/rocketchat-logger/server.js
Outdated
}); | ||
|
||
this.ready(); | ||
StdOut.on('write', function(string, item) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use arrow function here
rodrigok
approved these changes
Mar 29, 2017
Syirrus
pushed a commit
to Syirrus/Rocket.Chat
that referenced
this pull request
Mar 31, 2017
…nto clarapy-v4 Changed over home.coffee & help.coffee to .js * 'develop' of https://github.com/RocketChat/Rocket.Chat: (162 commits) Remove coffeescript package from ui-flextab Remove coffeescript package from ui-sidenav Update PULL_REQUEST_TEMPLATE.md Fix Outgoing Webhooks Retrying Not Respecting Enabled Status (RocketChat#6478) Convert Theme Package to JS (RocketChat#6491) Fix typo of the safari pinned tab label (RocketChat#6487) fix channel merge option of user preferences (RocketChat#6493) converted Rocketchat logger coffee to js (RocketChat#6495) converted rocketchat-integrations coffee to js (RocketChat#6502) 'allow reacting' should be a toggle option (RocketChat#6522) Add to HISTORY.md Fix backup codes remaining not showing Fix ESLint Fix ESLint Fix review Fix review Fix review fix import issue fix fix ... # Conflicts: # packages/rocketchat-lib/server/lib/PushNotification.js # packages/rocketchat-ui/client/views/app/home.coffee # packages/rocketchat-ui/package.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core